Allow ingesting native histograms #5986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanprot
reviewed
May 29, 2024
yeya24
force-pushed
the
ingest-histograms
branch
2 times, most recently
from
2a76a63 to
0abc03c
Compare
friedrichg
reviewed
May 30, 2024
| @@ -1441,4 +1441,8 @@ blocks_storage: | |||
| # be out-of-order. | |||
| # CLI flag: -blocks-storage.tsdb.out-of-order-cap-max | |||
| [out_of_order_cap_max: <int> | default = 32] | |||
|
|
|||
| # [EXPERIMENTAL] True to enable native histogram. | |||
There was a problem hiding this comment.
friedrichg
approved these changes
May 31, 2024
Note that this part is just ingestion and histograms are not queryable from Query Frontend at this point. It will be added in future PRs. |
alanprot
reviewed
Jun 3, 2024
yeya24
force-pushed
the
ingest-histograms
branch
2 times, most recently
from
3b8afc8 to
0068e73
Compare
|
@alanprot Can you please take another look? |
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
yeya24
force-pushed
the
ingest-histograms
branch
from
0068e73 to
684e656
Compare
alanprot
approved these changes
Jun 11, 2024
3 tasks
This was referenced Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Allow ingesting native histograms. Feature can be enabled in Ingester via
--blocks-storage.tsdb.enable-native-histogramsflag.Note: Not all ingestion and query tests are finished for Native histograms. I plan to create another PR to control the size of the PR itself
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]