Add filtering by health and state in list rules #6040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euniceek
force-pushed
the
implement-listrules-filtering
branch
from
3a39004 to
2e003fb
Compare
yeya24
reviewed
Jun 26, 2024
euniceek
force-pushed
the
implement-listrules-filtering
branch
from
2e003fb to
f182009
Compare
euniceek
force-pushed
the
implement-listrules-filtering
branch
from
f182009 to
aefd0ae
Compare
yeya24
approved these changes
Jun 28, 2024
|
@euniceek Can you please update the PR description? I don't think Cortex supports ruleinfo API |
Thanks for the review! Updated! |
|
Let's wait for another approval from a maintainer before merging this. |
|
@euniceek Can you also update the changelog? We can call it an |
euniceek
force-pushed
the
implement-listrules-filtering
branch
from
5dc7427 to
a3578f0
Compare
|
ok.. LGTM! |
alanprot
approved these changes
Jul 9, 2024
Signed-off-by: Eunice Kim <[email protected]>
Signed-off-by: Eunice Kim <[email protected]>
euniceek
force-pushed
the
implement-listrules-filtering
branch
from
a3578f0 to
2e74e23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds two additional filtering fields to the list rules API. If users want to list rules that are in firing state or healthy, they will be able to do it using the following parameters.
api/v1/rules?state=firingapi/v1/rules?health=okChecklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]