Differentiate retry and halt error and retry failed compaction only on retriable error #6111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etriable error Signed-off-by: Alex Le <[email protected]>
Signed-off-by: Alex Le <[email protected]>
yeya24
reviewed
Jul 23, 2024
Signed-off-by: Alex Le <[email protected]>
…label Signed-off-by: Alex Le <[email protected]>
danielblando
approved these changes
Jul 23, 2024
Signed-off-by: Alex Le <[email protected]>
yeya24
reviewed
Jul 23, 2024
Signed-off-by: Alex Le <[email protected]>
yeya24
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Currently, Cortex would retry any error from compaction. However, some error would be for sure fail again on retry. This PR adds logic to differentiate halt and retriable error (from Thanos). Cortex compactor should only retry compaction on retriable errors. Also, added metrics to count halt and retriable errors separately
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]