fix regression of result cache unable to parse cached results #6196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR fixes a regression introduced in #6180.
any: message type \"queryrange.PrometheusResponse\" isn't linked in
error came from https://github.com/cortexproject/cortex/blob/v1.18.0/pkg/querier/tripperware/queryrange/results_cache.go#L733. When serializing query response into cacheable content the protobuf type name is encoded. So when fetching cached response back and deserializing it again it requires us to have thequeryrange.PrometheusResponse
type so it knows how to unmarshal it.The type was removed in the above PR. To fix this issue, we have to introduce
queryrange.PrometheusResponse
type back for compatibility purpose. The cache should be able to handle different cached result types and always convert result type to the new one when forwarding the response to downstream.Besides, I also ensure that we always write old response format to cache for backward compatiblity. So things don't break when there is a rollback and old image cannot parse the cached results.
The idea is to introduce a flag later so that users can migrate with a 2 phase deployment.
Which issue(s) this PR fixes:
Fixes #
Omit the changelog as the regression was not released yet.
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]