Skip to content

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Oct 11, 2024

What this PR does:

Follow up of #6261, update build image and update go version to 1.23.2

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@dosubot dosubot bot added component/build go Pull requests that update Go code labels Oct 11, 2024
Signed-off-by: Ben Ye <[email protected]>
@yeya24
Copy link
Contributor Author

yeya24 commented Oct 11, 2024

misspell -error docs
# Configured via .golangci.yml.
golangci-lint run
level=warning msg="[config_reader] The configuration option `output.format` is deprecated, please use `output.formats`"
level=warning msg="[config_reader] The configuration option `linters.errcheck.exclude` is deprecated, please use `linters.errcheck.exclude-functions`."
make: *** [Makefile:176: lint] Killed

Golangci-lint got OOM killed. We might want to see if it was the go version upgrade that caused this. I will see if it helps if upgrading to golangci-lint 1.60.1+

@yeya24 yeya24 mentioned this pull request Oct 11, 2024
3 tasks
@yeya24 yeya24 closed this in #6263 Oct 13, 2024
@yeya24
Copy link
Contributor Author

yeya24 commented Oct 13, 2024

Umm this one got closed accidentally, reopen now.

@yeya24 yeya24 reopened this Oct 13, 2024
@yeya24 yeya24 force-pushed the upgrade-go-1.23.2 branch from 5bffcd1 to 5756c6e Compare October 13, 2024 21:38
@yeya24
Copy link
Contributor Author

yeya24 commented Oct 13, 2024

It should be ready for review and merge to unblock updating Thanos and Prometheus version.

@yeya24 yeya24 requested a review from friedrichg October 14, 2024 05:00
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 14, 2024
@yeya24 yeya24 merged commit 1fb4cc1 into cortexproject:master Oct 14, 2024
16 checks passed
@yeya24 yeya24 deleted the upgrade-go-1.23.2 branch October 15, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/build go Pull requests that update Go code lgtm This PR has been approved by a maintainer size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants