Add support for native histograms in querier protobuf codec #6368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Hassan <[email protected]>
afhassan
commented
Nov 22, 2024
integration/native_histogram_test.go
Outdated
There was a problem hiding this comment.
The integration test is the same but runs twice now for each of the two querier codec flags
afhassan
commented
Nov 22, 2024
pkg/querier/codec/protobuf_codec.go
Outdated
| Sample: &cortexpb.Sample{ | ||
| vectorSamples[i].Labels = labels | ||
|
|
||
| if data.Result.(promql.Vector)[i].H != nil { |
There was a problem hiding this comment.
In the json_codec implementation we cannot have both a histogram and float at the same time for a vector sample
yeya24
approved these changes
Nov 24, 2024
Signed-off-by: Ahmed Hassan <[email protected]>
Signed-off-by: Ahmed Hassan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The current implementation of querier protobuf codec does not serialize prometheus native histograms. This PR allows querier protobuf codec to handle responses with native histograms.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]