Skip to content

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Dec 18, 2024

What this PR does:

With limits per label set change, we have visibility of usage of each label set in Ingester.

This PR adds new cortex_distributor_received_samples_per_labelset_total in distributor so that we can get ingestion rate per label set.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@dosubot dosubot bot added component/distributor type/observability To help know what is going on inside Cortex labels Dec 18, 2024
Copy link
Member

@alanprot alanprot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 18, 2024
@yeya24 yeya24 force-pushed the distributor-labelset-ingestion-rate branch from 2ee28a1 to 0cdf9e4 Compare December 19, 2024 00:53
@SungJin1212
Copy link
Member

LGTM!

@yeya24 yeya24 merged commit cfe7ac3 into cortexproject:master Dec 19, 2024
17 checks passed
@yeya24 yeya24 deleted the distributor-labelset-ingestion-rate branch December 19, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/distributor lgtm This PR has been approved by a maintainer size/L type/observability To help know what is going on inside Cortex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants