Flaky rules test fix #6549
Merged
Flaky rules test fix #6549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 24, 2025 14:36
These tests were flaky: sometimes they get evaluated before the test issues the GET request, sometimes they do not. Signed-off-by: Daniel Sabsay <[email protected]>
Signed-off-by: Daniel Sabsay <[email protected]>
dosubot
bot
added
component/rules
|
I realize this adds quite a bit of code to fix a very small problem... It could be simplified by comparing go structures directly using go-cmp with custom comparison functions to ignore certain fields. I like that the current tests compare JSON strings directly since that is the user-facing output, which is why I've done it like this. If anyone disagrees or sees a better way, I'm happy to adjust it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
These tests were flaky: sometimes they get evaluated before the test
issues the GET request, sometimes they do not.
The reproducers are:
This fixes the flakiness by removing evaluation-related fields from the response before comparing.
Which issue(s) this PR fixes:
Fixes #6546
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]