Query ingesters only for GetLabelNames and GetLabelValues if start time parameter is not specified #6618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we truncate response if |
…ovided Signed-off-by: Ahmed Hassan <[email protected]>
afhassan
force-pushed
the
fix-get-labels-range-limit
branch
from
c05250c to
700b1c2
Compare
Signed-off-by: Ahmed Hassan <[email protected]>
This reverts commit 4301baf. Signed-off-by: Ahmed Hassan <[email protected]>
… time provided" This reverts commit 700b1c2. Signed-off-by: Ahmed Hassan <[email protected]>
Signed-off-by: Ahmed Hassan <[email protected]>
afhassan
force-pushed
the
fix-get-labels-range-limit
branch
from
cc37538 to
3e5e76a
Compare
|
Seems we had a discussion in the past about this break change for GetSeries. #4976 Can you update docs as we did them? |
Signed-off-by: Ahmed Hassan <[email protected]>
afhassan
changed the title
Signed-off-by: Ahmed Hassan <[email protected]>
Do we truncate for GetSeries? I think if the purpose of this PR is to avoid OOM, we should still truncate. If customer wants, it can explicit suggest the time range |
Yes we still truncate since we completely skip enforcing the max query length limit. I do agree it is better to still truncate. |
danielblando
approved these changes
Mar 18, 2025
yeya24
approved these changes
Mar 19, 2025
Signed-off-by: Ahmed Hassan <[email protected]>
Signed-off-by: Ahmed Hassan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
GetSeries,GetLabelNames, andGetLabelValuesAPI endpoints have optional start and end time parameters. If user does not specify a start or end time parameter, we set them toMinTimeandMaxTime.This causes
GetLabelNamesandGetLabelValuesto fail if start or end are not specified due to exceedingmaxQueryLengthlimitFor
GetSeries, we fallback to querying only ingesters if the start time is not specified. This PR changes the behaviour for bothGetLabelNamesandGetLabelValuesto also query ingesters if start time parameter is not specified.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]