Keep readonly state when stopping lifecycler #6642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Deluiggi <[email protected]>
danielblando
changed the title
Signed-off-by: Daniel Deluiggi <[email protected]>
Signed-off-by: Daniel Deluiggi <[email protected]>
danielblando
force-pushed
the
readonly-lifecycler
branch
from
90e3ee5 to
7029dee
Compare
alexqyle
reviewed
Mar 12, 2025
|
LGTM |
Signed-off-by: Daniel Deluiggi <[email protected]>
alanprot
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
When restarting ingester which are in READONLY we can cause a resharding which this PR is trying to avoid.
When a ingester is in READONLY, we extend the shard of tenant to return more than the original value. This is done to avoid errors on Push or missing data on Query.
Problem occurs when we restart ingester. The READONLY ingester will go to LEAVING which is ok for Push but it changes the tenant shard for Query. It can lead to miss calls from querier/ruler to ingesters.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]