Make ooo native histograms ingestion automatically enabled #6663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SungJin1212
force-pushed
the
Make-ooo-NH-ingestion-always-enable
branch
from
11847fa to
31929d3
Compare
SungJin1212
changed the title
SungJin1212
force-pushed
the
Make-ooo-NH-ingestion-always-enable
branch
from
31929d3 to
4744986
Compare
SungJin1212
force-pushed
the
Make-ooo-NH-ingestion-always-enable
branch
3 times, most recently
from
bf771c3 to
f75d87e
Compare
SungJin1212
changed the title
|
How about enabling NH ingestion by default to expand the user pool to use it? |
friedrichg
approved these changes
Mar 24, 2025
yeya24
requested changes
Mar 25, 2025
SungJin1212
force-pushed
the
Make-ooo-NH-ingestion-always-enable
branch
from
f75d87e to
ab079eb
Compare
SungJin1212
force-pushed
the
Make-ooo-NH-ingestion-always-enable
branch
from
ab079eb to
53320c5
Compare
yeya24
reviewed
Mar 25, 2025
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
Make-ooo-NH-ingestion-always-enable
branch
from
53320c5 to
370988b
Compare
CharlieTLe
approved these changes
Mar 25, 2025
|
@CharlieTLe there is no flag being removed as the flag was added recently and has not been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes out-of-order ingestion for native histograms automatically enabled when
-ingester.out-of-order-time-window > 0and-blocks-storage.tsdb.enable-native-histograms=trueas the Prometheus changed its behavior at the prometheus/prometheus#16207.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]