ruler/decoder: ensure labels order #6682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the labels are in order because we are iterating over map[string]string which has a random sorting order. I think the consequence of not sorting this is that when using a frontend directly, the write requests might have unsorted labels in them. Signed-off-by: Giedrius Statkevičius <[email protected]>
dosubot
bot
added
the
component/rules
|
Thanks |
SungJin1212
approved these changes
Apr 1, 2025
yeya24
approved these changes
Apr 3, 2025
wilguo
pushed a commit
to wilguo/cortex
that referenced
this pull request
Apr 10, 2025
Ensure that the labels are in order because we are iterating over map[string]string which has a random sorting order. I think the consequence of not sorting this is that when using a frontend directly, the write requests might have unsorted labels in them. Signed-off-by: Giedrius Statkevičius <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the labels are in order because we are iterating over map[string]string which has a random sorting order. I think the consequence of not sorting this is that when using a frontend directly, the write requests might have unsorted labels in them.