Skip to content

Upgrade promqlsmith version to latest #6689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2025
Merged

Upgrade promqlsmith version to latest #6689

merged 2 commits into from
Apr 8, 2025

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Apr 7, 2025 •
edited
Loading

What this PR does:

Upgrade promqlsmith to cortexproject/promqlsmith#155.

This includes:

  • Built-in max depth limit so we don't have to check generated query depth on Cortex
  • Better support for generating queries with vector matching. But we are not enabling it in this PR

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@dosubot dosubot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Apr 7, 2025
@yeya24
fix lint
191a767 
Signed-off-by: yeya24 <[email protected]>
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 8, 2025
@yeya24 yeya24 merged commit 531dd58 into cortexproject:master Apr 8, 2025
17 checks passed
@yeya24 yeya24 deleted the upgrade-promqlsmith branch April 8, 2025 22:12
wilguo pushed a commit to wilguo/cortex that referenced this pull request Apr 10, 2025
@yeya24 @wilguo
Upgrade promqlsmith version to latest (cortexproject#6689)
97d558b 
* upgrade promqlsmith version to latest

Signed-off-by: yeya24 <[email protected]>

* fix lint

Signed-off-by: yeya24 <[email protected]>

---------

Signed-off-by: yeya24 <[email protected]>
@CharlieTLe CharlieTLe mentioned this pull request Jul 26, 2025
Closed
@CharlieTLe CharlieTLe mentioned this pull request Aug 10, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanprot alanprot alanprot approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code lgtm This PR has been approved by a maintainer size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yeya24 @alanprot