Skip to content

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Apr 24, 2025

What this PR does:

This PR extends the existing bucket index file to add parquet metadata info to blocks. Read path can use the same bucket index file to discover parquet files.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@dosubot dosubot bot added component/compactor storage/blocks Blocks storage engine labels Apr 24, 2025
@yeya24 yeya24 marked this pull request as draft April 24, 2025 01:48
@yeya24 yeya24 changed the title Extend bucket index to add section for parquet blocks Extend bucket index to add parquet fields to block Apr 24, 2025
@yeya24 yeya24 marked this pull request as ready for review April 24, 2025 15:53
@yeya24 yeya24 force-pushed the extend-bucket-index-parquet branch from 0b067df to 11f1911 Compare April 29, 2025 02:52
Copy link
Member

@alanprot alanprot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

This looks good!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 29, 2025
@yeya24 yeya24 merged commit 59e7d6c into cortexproject:master Apr 30, 2025
17 checks passed
@yeya24 yeya24 deleted the extend-bucket-index-parquet branch April 30, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/compactor lgtm This PR has been approved by a maintainer size/L storage/blocks Blocks storage engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants