Add ingester.skip-metadata-limits flag #6744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SungJin1212
force-pushed
the
Add-ingester.skip-metadata-limits-flag
branch
from
e320d31 to
c12bca2
Compare
3 tasks
yeya24
approved these changes
May 15, 2025
| "github.com/cortexproject/cortex/integration/e2ecortex" | ||
| ) | ||
|
|
||
| func TestMetadataAPIWhenDeployment(t *testing.T) { |
There was a problem hiding this comment.
Thanks for adding this test. There is already a backward compatibility test in https://github.com/cortexproject/cortex/blob/master/integration/backward_compatibility_test.go. Is it easy to reuse that? Not blocking this PR
It is ok to keep this test case as is
There was a problem hiding this comment.
I think the test is more suitable for backward_compatibility, so I migrated it.
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
Add-ingester.skip-metadata-limits-flag
branch
from
c12bca2 to
44d7d33
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #6681 implements a metadata API query parameter (limit, limit_per_metric, and metric). During a deployment when the querier is on an older version and the ingester is on a new version, the querier always passes 0 values for limits. If then, the ingester returns an empty response.
This PR adds a
-ingester.skip-metadata-limitsflag to make the ingester return metadata during the deployment. After the deployment, set this flag tofalseto use the metadata API with the limits.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]