Skip to content

Conversation

SungJin1212
Copy link
Member

The PR #6681 implements a metadata API query parameter (limit, limit_per_metric, and metric). During a deployment when the querier is on an older version and the ingester is on a new version, the querier always passes 0 values for limits. If then, the ingester returns an empty response.
This PR adds a-ingester.skip-metadata-limits flag to make the ingester return metadata during the deployment. After the deployment, set this flag to false to use the metadata API with the limits.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@SungJin1212 SungJin1212 force-pushed the Add-ingester.skip-metadata-limits-flag branch from e320d31 to c12bca2 Compare May 15, 2025 07:10
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

"github.com/cortexproject/cortex/integration/e2ecortex"
)

func TestMetadataAPIWhenDeployment(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this test. There is already a backward compatibility test in https://github.com/cortexproject/cortex/blob/master/integration/backward_compatibility_test.go. Is it easy to reuse that? Not blocking this PR

It is ok to keep this test case as is

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the test is more suitable for backward_compatibility, so I migrated it.

Copy link
Contributor

@harry671003 harry671003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@SungJin1212 SungJin1212 force-pushed the Add-ingester.skip-metadata-limits-flag branch from c12bca2 to 44d7d33 Compare May 16, 2025 02:15
@yeya24 yeya24 merged commit 444c8e8 into cortexproject:master May 16, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants