Skip to content

Conversation

justinjung04
Copy link
Contributor

@justinjung04 justinjung04 commented May 28, 2025

What this PR does:

This PR enhances partial data feature used in ingesters and rulers with the followings:

  1. If queryable return 422, return 422 instead of partial data
  2. If at least half of ingesters are down, return 5xx instead of partial data
  3. Enhance partial data log with user and request info

Which issue(s) this PR fixes:
n/a

Checklist

  • Tests updated
  • [n/a] Documentation added
  • [n/a] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Justin Jung <[email protected]>
@justinjung04
Copy link
Contributor Author

I thought these are minor improvements that don't need to be in the changelog, but please let me know if you'd like me to add.

Signed-off-by: Justin Jung <[email protected]>
@pull-request-size pull-request-size bot added size/L and removed size/M labels May 29, 2025
@justinjung04 justinjung04 force-pushed the partial-data branch 2 times, most recently from 7ff2512 to 7777301 Compare May 29, 2025 15:08
@justinjung04
Copy link
Contributor Author

The test-no-race is failing due to issue unrelated to this PR. Here's the fix: #6768

Signed-off-by: Justin Jung <[email protected]>
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yeya24 yeya24 merged commit ff91465 into cortexproject:master May 30, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants