Proposal for distributed query execution #6789
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>
yeya24
approved these changes
Jun 4, 2025
yeya24
reviewed
Jun 4, 2025
alanprot
reviewed
Jun 4, 2025
alanprot
reviewed
Jun 4, 2025
|
This looks great! I cannot wait to see it working! :D:D:D |
Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>
harry671003
force-pushed
the
proposal_distributed_query
branch
from
ea50781 to
37692c4
Compare
yeya24
reviewed
Jun 6, 2025
|
|
||
| ``` | ||
| service QueryServer { | ||
| rpc Series(SeriesRequest) returns (stream OneSeries); |
There was a problem hiding this comment.
This should stream a batch of series, not just one?
|
|
||
| #### Co-ordinated Execution | ||
|
|
||
| The querier assigned the **root fragment** also plays the role of **coordinator**. The co-ordinator will |
There was a problem hiding this comment.
The root querier will call Series and Next to the child querier. Those requests will also specify the logical plan ID or some sort of request ID so the child querier finds out the actual plan?
yeya24
reviewed
Jun 6, 2025
| ``` | ||
| service QueryServer { | ||
| rpc Series(SeriesRequest) returns (stream OneSeries); | ||
| rpc Next(NextRequest) returns (stream StepVectorBatch); |
There was a problem hiding this comment.
Maybe we need some marker a mark finish for both series and next. Do we just use EOF?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Submits a proposal for distributed query execution in Cortex using Thanos PromQL engine.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]