Add active series limit for native histogram samples #6796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harry671003
reviewed
Jun 6, 2025
yeya24
reviewed
Jun 10, 2025
CHANGELOG.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| # Changelog | |||
|
|
|||
| ## master / unreleased | |||
| * [ENHANCEMENT] Ingester: Add activeSeries limit specifically for NativeHistograms. #6796 | |||
There was a problem hiding this comment.
This changelog item needs to be grouped with other enhancement items
There was a problem hiding this comment.
Thanks. Updated.
There was a problem hiding this comment.
Please remove this line since you already added it below
PaurushGarg
changed the title
PaurushGarg
force-pushed
the
native-histograms-active-series-limit
branch
from
024c1e9 to
ab7970d
Compare
harry671003
reviewed
Jun 24, 2025
yeya24
approved these changes
Jun 29, 2025
pkg/ingester/limiter.go
Outdated
| localLimit := l.limits.MaxLocalNativeHistogramSeriesPerUser(userID) | ||
| globalLimit := l.limits.MaxGlobalNativeHistogramSeriesPerUser(userID) | ||
|
|
||
| return fmt.Errorf("per-user nativeHistograms series limit of %d exceeded, %s (local limit: %d global limit: %d actual local limit: %d)", |
There was a problem hiding this comment.
Let's be consistent with other messages. per-user native histogram series limit...
PaurushGarg
changed the title
yeya24
approved these changes
Jun 30, 2025
Signed-off-by: Paurush Garg <[email protected]>
PaurushGarg
force-pushed
the
native-histograms-active-series-limit
branch
from
0d0a007 to
5e35219
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In addition to the current active series limit on float+histogram samples, this PR adds an active series limit for specifically for native histogram
samples.
This is done, b/c the ingestion of native histogram samples is much more CPU intensive than that of float samples - adding native histogram samples specific ingestion limit to protect the service and to allow clients to adjust the NH series ingestion.
Currently, Prometheus doesn't provide a way to count the specific active native histogram series in the head and hence this PR uses the activeNativeHistogram series count from Cortex - which differs in the way active series is counted.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]