Skip to content

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Jun 6, 2025

What this PR does:

Disable topk and bottomk aggregation in query fuzz test since they are quite flaky

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Member

@alanprot alanprot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 6, 2025
@yeya24 yeya24 merged commit a73deb4 into cortexproject:master Jun 6, 2025
16 of 17 checks passed
@yeya24 yeya24 deleted the disable-topk-bottomk branch June 6, 2025 19:35
@dsabsay
Copy link
Contributor

dsabsay commented Jun 6, 2025

FYI, I think it may be a combination of topk/bottomk and other things. See #6653

@yeya24
Copy link
Contributor Author

yeya24 commented Jun 6, 2025

@dsabsay Thanks. I think we are aware of the issue of bottomk and topk for a long time. We made some attempts before to use different comparator or something. I would say we just disable it due to the flakeness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size/S type/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants