Improving logs and adding some spans on the parquet queryable #6806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanprot
force-pushed
the
add-logs-span-parquet
branch
from
b512b2f to
23a9dd0
Compare
Signed-off-by: alanprot <[email protected]>
alanprot
force-pushed
the
add-logs-span-parquet
branch
from
23a9dd0 to
35f9611
Compare
dosubot
bot
added
component/querier
type/observability
Signed-off-by: alanprot <[email protected]>
yeya24
reviewed
Jun 8, 2025
pkg/querier/parquet_queryable.go
Outdated
| @@ -146,6 +147,9 @@ func NewParquetQueryable( | |||
| shards := make([]*parquet_storage.ParquetShard, len(blocks)) | |||
| errGroup := &errgroup.Group{} | |||
|
|
|||
| span, _ := opentracing.StartSpanFromContext(ctx, "parquetQuerierWithFallback.OpenShards") | |||
There was a problem hiding this comment.
Do we need to pass ctx to parquet_storage.OpenParquetShard?
There was a problem hiding this comment.
good call.. lemme try wihtouc cancel
Signed-off-by: alanprot <[email protected]>
yeya24
pushed a commit
to yeya24/cortex
that referenced
this pull request
Jun 10, 2025
…project#6806) * Improving logs and adding some spans on the parquet queriable Signed-off-by: alanprot <[email protected]> * lint Signed-off-by: alanprot <[email protected]> * comments Signed-off-by: alanprot <[email protected]> --------- Signed-off-by: alanprot <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Just improving logs and adding some traces spans on the parquet queryable.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]