Skip to content

Add cleaner and converter metrics for parquet #6809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2025
Merged

Add cleaner and converter metrics for parquet #6809

merged 2 commits into from
Jun 10, 2025
+234 −10

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Jun 10, 2025 •
edited
Loading

What this PR does:

Added some basic metrics for parquet. This is just a starting point and we can add more metrics for it.

Cleaner:

  • cortex_bucket_parquet_blocks_count. For number of parquet blocks for the tenant

Converter:

  • cortex_parquet_converter_converted_blocks_total. Number of converted blocks
  • cortex_parquet_converter_convert_block_duration_seconds. Last block conversion duration
  • cortex_parquet_converter_users_owned. Number of owned users for the converter instance

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@dosubot dosubot bot added the type/observability To help know what is going on inside Cortex label Jun 10, 2025
@yeya24
changelog
8d9f565 
Signed-off-by: yeya24 <[email protected]>
alanprot
alanprot approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member

@alanprot alanprot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 10, 2025
@yeya24 yeya24 merged commit 506be73 into cortexproject:master Jun 10, 2025
17 checks passed
@yeya24 yeya24 deleted the add-converter-cleaner-parquet-metrics branch June 10, 2025 23:29
@CharlieTLe CharlieTLe mentioned this pull request Jul 26, 2025
Closed
@CharlieTLe CharlieTLe mentioned this pull request Aug 10, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanprot alanprot alanprot approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size/L type/observability To help know what is going on inside Cortex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yeya24 @alanprot