Split compactor cleaner metrics #6827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielblando
force-pushed
the
compactor-metrics
branch
2 times, most recently
from
7145c40 to
d2b59a6
Compare
yeya24
reviewed
Jun 18, 2025
danielblando
force-pushed
the
compactor-metrics
branch
from
c31ac49 to
528e1ac
Compare
Signed-off-by: Daniel Deluiggi <[email protected]>
Signed-off-by: Daniel Deluiggi <[email protected]>
Signed-off-by: Daniel Deluiggi <[email protected]>
Signed-off-by: Daniel Deluiggi <[email protected]>
Signed-off-by: Daniel Deluiggi <[email protected]>
Signed-off-by: Daniel Deluiggi <[email protected]>
danielblando
force-pushed
the
compactor-metrics
branch
from
528e1ac to
4ec4681
Compare
|
LGTM |
bogdan-st
pushed a commit
to bogdan-st/cortex
that referenced
this pull request
Jun 30, 2025
* Split compactor cleaner metrics Signed-off-by: Daniel Deluiggi <[email protected]> * CHANGELOG Signed-off-by: Daniel Deluiggi <[email protected]> * fix lint Signed-off-by: Daniel Deluiggi <[email protected]> * update doc Signed-off-by: Daniel Deluiggi <[email protected]> * Address comments Signed-off-by: Daniel Deluiggi <[email protected]> * update doc Signed-off-by: Daniel Deluiggi <[email protected]> --------- Signed-off-by: Daniel Deluiggi <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
When cleanUpUser takes long it might delay compaction cleaner metrics leaving the user blind to what is happening. This approach separate metrics in another go routine which will run independently if the cleanUser is impaired
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]