Allow store gateway to ignore syncing blocks older than certain time #6830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: yeya24 <[email protected]>
yeya24
force-pushed
the
store-gateway-min-time
branch
from
1e029f7 to
b4763c1
Compare
Signed-off-by: yeya24 <[email protected]>
Signed-off-by: yeya24 <[email protected]>
Signed-off-by: yeya24 <[email protected]>
danielblando
approved these changes
Jun 19, 2025
|
LGTM! |
SungJin1212
approved these changes
Jun 20, 2025
Signed-off-by: yeya24 <[email protected]>
bogdan-st
pushed a commit
to bogdan-st/cortex
that referenced
this pull request
Jun 30, 2025
…ortexproject#6830) * allow store gateway to ignore syncing blocks older than certain time Signed-off-by: Ben Ye <[email protected]> * changelog Signed-off-by: yeya24 <[email protected]> * fix handling default value 0 Signed-off-by: yeya24 <[email protected]> * fix Signed-off-by: yeya24 <[email protected]> * refactor code a bit Signed-off-by: yeya24 <[email protected]> * update unit test Signed-off-by: yeya24 <[email protected]> --------- Signed-off-by: Ben Ye <[email protected]> Signed-off-by: yeya24 <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add
ignore_blocks_beforeconfig so that Store Gateway won't sync blocks that are too old. This can be useful for tiered Store Gateway deployment. Another use case is when migrating to Parquet based storage, Store Gateway can be gradually scale down so we can use this config to load less blocks.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]