Skip to content

Conversation

SungJin1212
Copy link
Member

@SungJin1212 SungJin1212 commented Jun 25, 2025

The NewOverrides always return nil err. So, this PR deletes it to remove the unnecessary error handling.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@SungJin1212 SungJin1212 force-pushed the Delete-NewOverrides-error branch from 6c9080f to 7266961 Compare June 25, 2025 10:06
@dosubot dosubot bot added the type/chore Something that needs to be done; not a bug or a feature label Jun 25, 2025
Copy link
Contributor

@danielblando danielblando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@yeya24 yeya24 merged commit f236c52 into cortexproject:master Jun 29, 2025
17 checks passed
bogdan-st pushed a commit to bogdan-st/cortex that referenced this pull request Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L type/chore Something that needs to be done; not a bug or a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants