Skip to content

Conversation

alanprot
Copy link
Member

@alanprot alanprot commented Jul 8, 2025

What this PR does:
Update parquet common to latest.

Benchmark is showing very good opmizations:

image

Which issue(s) this PR fixes:
Fixes #

Checklist

  • [NA] Tests updated
  • [NA] Documentation added
  • [NA] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@alanprot alanprot marked this pull request as ready for review July 8, 2025 18:07
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dosubot dosubot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jul 8, 2025
@yeya24 yeya24 self-requested a review July 8, 2025 19:51
@yeya24
Copy link
Contributor

yeya24 commented Jul 8, 2025

Seems we have some panic here.

 18:58:17 cortex: panic: runtime error: invalid memory address or nil pointer dereference
18:58:17 cortex: [signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x2adb906]
18:58:17 cortex: goroutine 3247 [running]:
18:58:17 cortex: github.com/prometheus-community/parquet-common/queryable.newQueryableShard(0xc000167e70, {0x0, 0x0}, 0xc000dda290)
18:58:17 cortex: /__w/cortex/cortex/vendor/github.com/prometheus-community/parquet-common/queryable/parquet_queryable.go:211 +0x26
18:58:17 cortex: github.com/prometheus-community/parquet-common/queryable.parquetQuerier.queryableShards({0x197e640a3fc, 0x197eb30117c, 0xc000db1440, 0xc000dda290, 0xc000167e70}, {0x4318778?, 0xc04dff3350?}, 0x30?, 0x38c3ba0?)
18:58:17 cortex: /__w/cortex/cortex/vendor/github.com/prometheus-community/parquet-common/queryable/parquet_queryable.go:195 +0xc9
18:58:17 cortex: github.com/prometheus-community/parquet-common/queryable.parquetQuerier.Select({0x197e640a3fc, 0x197eb30117c, 0xc000db1440, 0xc000dda290, 0xc000167e70}, {0x4318778, 0xc04dff3350}, 0x1, 0xc04e9a6cb0, {0xc0005bd748, ...})
18:58:17 cortex: /__w/cortex/cortex/vendor/github.com/prometheus-community/parquet-common/queryable/parquet_queryable.go:157 +0xe5
18:58:17 cortex: github.com/cortexproject/cortex/pkg/querier.(*parquetQuerierWithFallback).Select.func1()
18:58:17 cortex: /__w/cortex/cortex/pkg/querier/parquet_queryable.go:429 +0x198
18:58:17 cortex: created by github.com/cortexproject/cortex/pkg/querier.(*parquetQuerierWithFallback).Select in goroutine 3299
18:58:17 cortex: /__w/cortex/cortex/pkg/querier/parquet_queryable.go:426 +0x468
    query_fuzz_test.go:1750: 
        	Error Trace:	/home/runner/work/cortex/cortex/integration/query_fuzz_test.go:1750
        	            				/home/runner/work/cortex/cortex/integration/parquet_querier_test.go:172
        	Error:      	Received unexpected error:
        	            	Post "http://127.0.0.1:32771/api/prom/api/v1/series": EOF
        	Test:       	TestParquetFuzz

Signed-off-by: alanprot <[email protected]>
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 8, 2025
@alanprot alanprot merged commit 91b1377 into cortexproject:master Jul 8, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code lgtm This PR has been approved by a maintainer size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants