Skip to content

*: Update prometheus/thanos/promql-engine #6930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

*: Update prometheus/thanos/promql-engine #6930

merged 1 commit into from
Jul 31, 2025

Conversation

harry671003
Copy link
Contributor

@harry671003 harry671003 commented Jul 31, 2025 •
edited
Loading

What this PR does:

  • Updating prometheus/thanos/promql-engine to latest
  • Handling stringlabels being default
    • Prometheus made stringlabels the default build flag in Use stringlabels by default prometheus/prometheus#16436
    • In Cortex, we still continue to use the old behaviour by passing the slicelabels build tag
    • But lint doesn't work without us switching to use functions like Range(), Map(), Len() etc instead of directly using slice builtins

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@harry671003 harry671003 force-pushed the prom_update branch 12 times, most recently from abecd83 to 4bfe5b9 Compare July 31, 2025 17:47
@harry671003
*: Update prometheus/thanos/promql-engine
43ec2b6 
Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>
@harry671003 harry671003 marked this pull request as ready for review July 31, 2025 18:37
@dosubot dosubot bot added the go Pull requests that update Go code label Jul 31, 2025
danielblando
danielblando approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@danielblando danielblando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

yeya24
yeya24 approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is great work!

@yeya24 yeya24 merged commit e31c57c into cortexproject:master Jul 31, 2025
31 of 32 checks passed
@CharlieTLe CharlieTLe mentioned this pull request Aug 10, 2025
Open
3 tasks
@harry671003 harry671003 mentioned this pull request Aug 19, 2025
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielblando danielblando danielblando approved these changes

@yeya24 yeya24 yeya24 approved these changes

Assignees
No one assigned
Labels
go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harry671003 @danielblando @yeya24