Skip to content

query rejection blog post improvement #6949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erlan-z
Copy link
Contributor

@erlan-z erlan-z commented Aug 6, 2025

What this PR does:

Improves query rejection blog post.

  • added Ruler Queries part.
  • there was an error on example query, so fixed it.
  • Some other wording changes for overall improvement.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@erlan-z erlan-z marked this pull request as draft August 6, 2025 17:02
@erlan-z erlan-z force-pushed the blog-query-rejection branch from 4cb8fdd to 3e0fa04 Compare August 8, 2025 17:54
@pull-request-size pull-request-size bot added size/M and removed size/XS labels Aug 8, 2025
@erlan-z erlan-z mentioned this pull request Aug 8, 2025
3 tasks
@yeya24
Copy link
Contributor

yeya24 commented Aug 9, 2025

@rajagopalanand Can you also help take a look as rule group rejection is also included in the blog post?

Copy link
Contributor

@rajagopalanand rajagopalanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. Just had a question

@@ -103,9 +103,25 @@ Because this request matches all the configured attributes, it will be blocked.

- **Communicate with tenants.** Let affected tenants know if their queries are being blocked, and help them adjust their dashboards accordingly.

## Conclusion
## Ruler Queries
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When talking about disabling rule groups, do we want to mention this can be used to prevent rulers from getting OOM killed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this

Signed-off-by: Erlan Zholdubai uulu <[email protected]>
@erlan-z erlan-z force-pushed the blog-query-rejection branch from 3e0fa04 to feb1c07 Compare August 21, 2025 23:04
@erlan-z erlan-z marked this pull request as ready for review August 21, 2025 23:05
@erlan-z erlan-z requested a review from rajagopalanand August 21, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants