-
Notifications
You must be signed in to change notification settings - Fork 195
Update dependencies #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
coryhouse
wants to merge
23
commits into
master
Choose a base branch
from
update-dependencies
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
17f978e
Update to Webpack 2. Update dependencies.
coryhouse 9837ba5
Fix syntax errors
coryhouse b851de8
Merge branch 'master' into update-dependencies
coryhouse 2540ce9
Upgrade dependencies
coryhouse d3a6aee
Upgrade packages
coryhouse 5b8a253
Switch to babel-preset-env which replaced babel-preset-latest
f57e2d7
Remove needless escape characters
27341a5
Update dependencies
890b415
Update webpack.config to modern syntax
30a70fb
Update dependencies including Webpack 4
coryhouse bebdb27
Update webpack.config.prod.js
coryhouse 751c4b7
Remove nsp since npm has security checks built in now
coryhouse fa4732b
Merge branch 'update-dependencies' of https://github.com/coryhouse/ja…
coryhouse 838e8b4
Update dependencies
coryhouse 946d4eb
Upgrade Babel and ESLint
coryhouse 90f42b2
Merge branch 'master' into update-dependencies
coryhouse 9f84e57
Update deps
coryhouse ae1c8ec
Merge branch 'update-dependencies' of https://github.com/coryhouse/ja…
coryhouse c9dfefb
Comment tweak
coryhouse 56bd631
Upgrade jsdom
coryhouse f41c337
Upgrade dependencies
coryhouse cafcf84
Simplify babel config
coryhouse 21f1fc8
Remove unused file
coryhouse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
{ | ||
"presets": [ | ||
"latest" | ||
] | ||
"presets": ["@babel/preset-env"] | ||
} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
// This file isn't transpiled, so must use CommonJS and ES5 | ||
|
||
// Register babel to transpile before our tests run. | ||
require('babel-register')(); | ||
require('@babel/register')(); | ||
|
||
// Disable webpack features that Mocha doesn't understand. | ||
require.extensions['.css'] = function() {}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ES2015 modules can be parsed by webpack 2. This enables tree shaking in the production build by disabling Babel's transpilation of ES2015 modules. Since ES2015 modules are statically analyzable, webpack can determine with certainly what code you're not calling, and leave it out of the bundle. This process can reduce your final bundle size. It's commonly called tree shaking or dead code elimination.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also switched to babel-preset-env since it replaced babel-preset-latest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to update all "latest" with "env" in .babelrc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jcscott2015 - Correct, and I did that as you can see above.