Upgrade go-ethereum to 1.13 #116

vladjdk · 2025-04-29T19:11:43Z

requires: cosmos/go-ethereum#2
closes: #115

bump geth to v1.13

Eric-Warehime · 2025-04-29T21:46:58Z

go.mod

 	// use Cosmos-SDK fork to enable Ledger functionality
 	github.com/cosmos/cosmos-sdk => github.com/cosmos/cosmos-sdk v0.50.13-0.20250319183239-53dea340efc7
 	// use Cosmos geth fork
-	github.com/ethereum/go-ethereum => github.com/cosmos/go-ethereum v1.10.26-evmos-rc4.0.20250402013457-cf9d288f0147
+	github.com/ethereum/go-ethereum => github.com/TacBuild/go-ethereum v0.0.0-20250428082551-b4f5a8f8420a


Can you update this to point at https://github.com/cosmos/go-ethereum/releases/tag/v1.13.5-cosmos-rc0

Eric-Warehime · 2025-04-29T21:55:33Z

local_node.sh

@@ -137,6 +137,12 @@ if [[ $overwrite == "y" || $overwrite == "Y" ]]; then
 	# Enable precompiles in EVM params
 	jq '.app_state["evm"]["params"]["active_static_precompiles"]=["0x0000000000000000000000000000000000000100","0x0000000000000000000000000000000000000400","0x0000000000000000000000000000000000000800","0x0000000000000000000000000000000000000801","0x0000000000000000000000000000000000000802","0x0000000000000000000000000000000000000803","0x0000000000000000000000000000000000000804","0x0000000000000000000000000000000000000805"]' "$GENESIS" >"$TMP_GENESIS" && mv "$TMP_GENESIS" "$GENESIS"

+	# Set EVM config
+	jq '.app_state["evm"]["params"]["chain_config"]["chain_id"]="262144"' "$GENESIS" >"$TMP_GENESIS" && mv "$TMP_GENESIS" "$GENESIS"


Can you use the $CHAINID variable here?

Eric-Warehime · 2025-04-29T22:02:51Z

ante/evm/07_can_transfer.go


 	// check that caller has enough balance to cover asset transfer for **topmost** call
 	// NOTE: here the gas consumed is from the context with the infinite gas meter
-	if msg.Value().Sign() > 0 && !evm.Context.CanTransfer(stateDB, msg.From(), msg.Value()) {
+	if msg.Value.Sign() > 0 && !evm.Context.CanTransfer(stateDB, msg.From, uint256.MustFromBig(msg.Value)) {


Is it actually safe to panic here? Seems like we want to return an error on failure.

Eric-Warehime · 2025-04-29T22:12:11Z

precompiles/ics20/tx.go

@@ -75,7 +76,7 @@ func (p *Precompile) Transfer(
 		// NOTE: This ensures that the changes in the bank keeper are correctly mirrored to the EVM stateDB
 		// when calling the precompile from another smart contract.
 		// This prevents the stateDB from overwriting the changed balance in the bank keeper when committing the EVM state.
-		amt := msg.Token.Amount.BigInt()
+		amt := uint256.MustFromBig(msg.Token.Amount.BigInt())


Also not sure if we should panic here ever.

Eric-Warehime · 2025-04-29T22:13:21Z

precompiles/staking/tx.go

@@ -242,7 +243,7 @@ func (p *Precompile) Delegate(

 		// Need to scale the amount to 18 decimals for the EVM balance change entry
 		scaledAmt := evmtypes.ConvertAmountTo18DecimalsBigInt(msg.Amount.Amount.BigInt())
-		p.SetBalanceChangeEntries(cmn.NewBalanceChangeEntry(delHexAddr, scaledAmt, cmn.Sub))
+		p.SetBalanceChangeEntries(cmn.NewBalanceChangeEntry(delHexAddr, uint256.MustFromBig(scaledAmt), cmn.Sub))


Same as above.

Eric-Warehime · 2025-04-29T22:23:05Z

x/vm/keeper/keeper.go

 	cosmosAddr := sdk.AccAddress(addr.Bytes())

 	// Get the balance via bank wrapper to convert it to 18 decimals if needed.
 	coin := k.bankWrapper.GetBalance(ctx, cosmosAddr, types.GetEVMCoinDenom())

-	return coin.Amount.BigInt()
+	return uint256.MustFromBig(coin.Amount.BigInt())


Same as above.

Eric-Warehime · 2025-04-29T22:25:55Z

x/vm/keeper/state_transition.go

-		ret, _, leftoverGas, vmErr = evm.Create(sender, msg.Data(), leftoverGas, msg.Value())
-		stateDB.SetNonce(sender.Address(), msg.Nonce()+1)
+		stateDB.SetNonce(sender.Address(), msg.Nonce)
+		ret, _, leftoverGas, vmErr = evm.Create(sender, msg.Data, leftoverGas, uint256.MustFromBig(msg.Value))


MustFromBig--same as above

Eric-Warehime · 2025-04-29T22:32:54Z

x/vm/types/params.go

 	// DefaultAllowUnprotectedTxs rejects all unprotected txs (i.e false)
 	DefaultAllowUnprotectedTxs = false
 	// DefaultStaticPrecompiles defines the default active precompiles.
 	DefaultStaticPrecompiles []string
 	// DefaultExtraEIPs defines the default extra EIPs to be included.
-	// On v15, EIP 3855 was enabled
-	DefaultExtraEIPs = []int64{
-		3855, // NOTE: we suggest to enable EIP-3855 on all chains to support new Solidity versions >=v0.8.20


Is this now default enabled so we don't need to add it to extra eips?

Eric-Warehime · 2025-04-29T22:33:44Z

x/vm/types/params.go

+	DefaultEVMDenom = "atest"
+	// DefaultEVMChainID is the default value for the evm chain ID
+	DefaultEVMChainID = "cosmos_262144-1"
+	// DefaultEVMDecimals is the default value for the evm denom decimal precision
+	DefaultEVMDecimals uint64 = 18


I think this stuff is probably best specified via the chain itself--like evmd could use these variables, but other chains should just get these as defaults.

dongsam · 2025-04-30T05:48:02Z

Hi, I’d like to ask a few questions regarding the upgrade to go-ethereum 1.15.x after this PR:

It seems that EIP-4844: Shard Blob Transactions is not applied in this v1.13 PR which added on Cancun(Dencun) hardfork with geth v1.13. Was this exclusion intentional, and is it expected to remain excluded?
Since BlobTxType is mainly used for rollup purposes from L2 to L1, is it acceptable to proceed with the 1.15.x upgrade even without including it? Have there been any indications of necessity from major chains that plan to use cosmos/evm?

c.c. @zsystm

zsystm · 2025-05-06T15:03:58Z

x/vm/keeper/state_transition.go

@@ -188,8 +190,8 @@ func (k *Keeper) ApplyTransaction(ctx sdk.Context, tx *ethtypes.Transaction) (*t
 	evmDenom := types.GetEVMCoinDenom()

 	// refund gas in order to match the Ethereum gas consumption instead of the default SDK one.
-	if err = k.RefundGas(ctx, msg, msg.Gas()-res.GasUsed, evmDenom); err != nil {
-		return nil, errorsmod.Wrapf(err, "failed to refund gas leftover gas to sender %s", msg.From())
+	if err = k.RefundGas(ctx, *msg, msg.GasLimit-res.GasUsed, evmDenom); err != nil {


@vladjdk

It looks like msg.GasLimit - res.GasUsed could underflow if GasUsed > GasLimit, resulting in a large wrapped uint64 value due to Go's unsigned arithmetic.

Might be safer to guard it like this:

remainingGas := uint64(0) if msg.GasLimit > res.GasUsed { remainingGas = msg.GasLimit - res.GasUsed }

And then pass remainingGas into RefundGas(...).

What do you think?

zsystm · 2025-05-06T15:10:30Z

x/vm/migrations/v9/migrate.go

+// MigrateStore migrates the x/evm module state from the consensus version 5 to
+// version 6. Specifically, it migrates the geth chain configuration


@vladjdk

Suggested change

// MigrateStore migrates the x/evm module state from the consensus version 5 to

// version 6. Specifically, it migrates the geth chain configuration

// MigrateStore migrates the x/evm module state from the consensus version 8 to

// version 9. Specifically, it migrates the geth chain configuration

GAtom22 and others added 6 commits April 21, 2025 19:04

bump geth to v1.13

8f2979f

remove gomod2nix file

ef6bdaf

update comment

6c64a94

Merge pull request #1 from GAtom22/GAtom22/bump-geth

fc6ee9a

bump geth to v1.13

update geth dep

a0c5f93

Merge pull request #2 from GAtom22/update-dep

38133c5

vladjdk changed the title ~~Bump geth to v1.13~~ Upgrade go-ethereum to 1.13 Apr 29, 2025

Eric-Warehime reviewed Apr 29, 2025

View reviewed changes

zsystm reviewed May 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade go-ethereum to 1.13 #116

Upgrade go-ethereum to 1.13 #116

vladjdk commented Apr 29, 2025

Eric-Warehime Apr 29, 2025

Eric-Warehime Apr 29, 2025

Eric-Warehime Apr 29, 2025

Eric-Warehime Apr 29, 2025

Eric-Warehime Apr 29, 2025

Eric-Warehime Apr 29, 2025

Eric-Warehime Apr 29, 2025

Eric-Warehime Apr 29, 2025

Eric-Warehime Apr 29, 2025

dongsam commented Apr 30, 2025

zsystm May 6, 2025

zsystm May 6, 2025

		// MigrateStore migrates the x/evm module state from the consensus version 5 to
		// version 6. Specifically, it migrates the geth chain configuration

Upgrade go-ethereum to 1.13 #116

Are you sure you want to change the base?

Upgrade go-ethereum to 1.13 #116

Conversation

vladjdk commented Apr 29, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dongsam commented Apr 30, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment