fix: align temporary reject check for included tx from txpool #494
+115
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladjdk
reviewed
Aug 22, 2025
vladjdk
requested changes
Aug 22, 2025
vladjdk
requested changes
Aug 22, 2025
| @@ -106,15 +104,13 @@ func (b *Backend) SendTransaction(args evmtypes.TransactionArgs) (common.Hash, e | |||
| syncCtx := b.ClientCtx.WithBroadcastMode(flags.BroadcastSync) | |||
| rsp, err := syncCtx.BroadcastTx(txBytes) | |||
| if rsp != nil && rsp.Code != 0 { | |||
| if shouldSkip, msg := HandleBroadcastRawLog(rsp.RawLog, txHash); shouldSkip { | |||
There was a problem hiding this comment.
We don't have a local TX tracker here, so we should just be returning the error until we implement that: https://github.com/cosmos/go-ethereum/blob/f70aaa8399ccee429804eecf3fc4c6fd8d9e6cab/eth/api_backend.go#L325-L341
I believe returning the error without a tx tracker is still considered EVM compatible, and we can create a separate issue to add one in.
|
@mmsqe looks like we have conflicts - thanks for the update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #493
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch