Skip to content

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Sep 4, 2025

Description

  • upstream cache params in object store from 454 456
  • add default and stm TxExecutor with patch tx responses to get rid of shared transient store
  • disable block gas meter after check gas wanted in ProcessProposal
  • for test info

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

Comment on lines +114 to +116
for k, v := range keys {
storeKeys[k] = v
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
Comment on lines +117 to +119
for k, v := range okeys {
storeKeys[k] = v
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
@mmsqe mmsqe changed the title feat: implement object stores feat: prepare parallel tx execution with object stores Sep 6, 2025
Comment on lines +1008 to +1010
for _, key := range app.keys {
keys = append(keys, key)
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
Comment on lines +1011 to +1013
for _, key := range app.tkeys {
keys = append(keys, key)
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
Comment on lines +1014 to +1016
for _, key := range app.memKeys {
keys = append(keys, key)
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
Comment on lines +1017 to +1019
for _, key := range app.okeys {
keys = append(keys, key)
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant