fix(mempool): checkTxHandler to handle invalid sequence tx #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudgray
changed the title
cloudgray
changed the title
vladjdk
requested changes
Sep 12, 2025
mempool/check_tx.go
Outdated
| @@ -18,7 +18,7 @@ func NewCheckTxHandler(mempool *ExperimentalEVMMempool) types.CheckTxHandler { | |||
| gInfo, result, anteEvents, err := runTx(request.Tx, nil) | |||
| if err != nil { | |||
| // detect if there is a nonce gap error (only returned for EVM transactions) | |||
| if errors.Is(err, ErrNonceGap) { | |||
| if errors.Is(err, ErrNonceGap) || errors.Is(err, sdkerrors.ErrInvalidSequence) { | |||
There was a problem hiding this comment.
Could we add a test that confirms that transactions that have already been included in a block will not be included in the mempool?
There was a problem hiding this comment.
Sure. I'll add test cases tomorrow.
There was a problem hiding this comment.
test case added! (839d35c)
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
CheckTxHandlerto allow tx with "invalid sequence" error.The purpose of this pr is aligning appside mempool with geth mempool.
Because current anteHandler rejects valid tx whose nonce is lower than tx in mempool,
CheckTxHandlershould handle this error and insert that tx into mempool.The reason why does not modify anteHandler but
CheckTxHandleris, if appside mempool is not enabled, validation of anteHandler is correct. So, we should modifyCheckTxHandlerthat is used for appside mempool.Closes: #590
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch