Skip to content

chore: add v11 e2e-upgrade-test and upgrade handler for simapp #8602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore: add v11 e2e-upgrade-test and upgrade handler for simapp #8602

wants to merge 5 commits into from

Conversation

anhductn2001
Copy link
Contributor

Description

closes: #8529

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Include changelog entry when appropriate (e.g. chores should be omitted from changelog).
  • Wrote unit and integration tests if relevant.
  • Updated documentation (docs/) if anything is changed.
  • Added godoc comments if relevant.
  • Self-reviewed Files changed in the GitHub PR explorer.
  • Provide a conventional commit message to follow the repository standards.

@codecov Codecov
Copy link

codecov bot commented Aug 12, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.31%. Comparing base (c0e6979) to head (945eecb).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8602   +/-   ##
=======================================
  Coverage   58.31%   58.31%           
=======================================
  Files         319      319           
  Lines       22821    22821           
=======================================
  Hits        13307    13307           
  Misses       8907     8907           
  Partials      607      607
Flag Coverage Δ
08-wasm 65.99% <ø> (ø)
e2e 1.14% <ø> (ø)
ibc-go 63.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anhductn2001
Copy link
Contributor Author

Currently when building and testing locally, I am getting an error when testing transfer after the upgrade:

Error Trace:    /Users/ducnt/Decentrio/Fork/ibc-go/e2e/testsuite/tx.go:124
                                                        /Users/ducnt/Decentrio/Fork/ibc-go/e2e/tests/upgrades/upgrade_test.go:1075
                Error:          Not equal: 
                                expected: 0xa
                                actual  : 0x0
                Test:           TestUpgradeTestSuite/TestV10ToV11ChainUpgrade
                Messages:       code: 10
                                codespace: channel
                                data: ""
                                events:
                                - attributes:
                                  - index: true
                                    key: fee
                                    value: ""
                                  - index: true
                                    key: fee_payer
                                    value: cosmos17srr8qck56ty45xfvk929t3nkxf8vsmttpmk8m
                                  type: tx
                                - attributes:
                                  - index: true
                                    key: acc_seq
                                    value: cosmos17srr8qck56ty45xfvk929t3nkxf8vsmttpmk8m/1
                                  type: tx
                                - attributes:
                                  - index: true
                                    key: signature
                                    value: DczCudSuxSnWuhaOjhPX2FCYEq9xiATnr/9SsFk4ruhiH0MGnNMGQMsFZfJo1rpL+7SksUAH58woinEAxgCf4Q==
                                  type: tx
                                gas_used: "59732"
                                gas_wanted: "5000000000"
                                height: "153"
                                info: ""
                                logs: []
                                raw_log: 'failed to execute message; message index: 0: source port: transfer, source
                                  channel: channel-0: sequence send not found'
                                timestamp: "2025-08-12T07:55:25Z"
                                tx:
                                  '@type': /cosmos.tx.v1beta1.Tx
                                  auth_info:
                                    fee:
                                      amount: []
                                      gas_limit: "5000000000"
                                      granter: ""
                                      payer: ""
                                    signer_infos:
                                    - mode_info:
                                        single:
                                          mode: SIGN_MODE_DIRECT
                                      public_key:
                                        '@type': /cosmos.crypto.secp256k1.PubKey
                                        key: A/f1N7tjk1bvQDUdSJYyi2LiUrA+eM+iHNuoxispuNI8
                                      sequence: "1"
                                    tip: null
                                  body:
                                    extension_options: []
                                    memo: interchaintest
                                    messages:
                                    - '@type': /ibc.applications.transfer.v1.MsgTransfer
                                      encoding: ""
                                      memo: ""
                                      receiver: cosmos14q46rqny20venwkrdq4quz3aydxh5zyzlg7ade
                                      sender: cosmos17srr8qck56ty45xfvk929t3nkxf8vsmttpmk8m
                                      source_channel: channel-0
                                      source_port: transfer
                                      timeout_height:
                                        revision_height: "1154"
                                        revision_number: "1"
                                      timeout_timestamp: "0"
                                      token:
                                        amount: "10000"
                                        denom: atoma
                                      use_aliasing: false
                                    non_critical_extension_options: []
                                    timeout_height: "0"
                                    timeout_timestamp: null
                                    unordered: false
                                  signatures:
                                  - DczCudSuxSnWuhaOjhPX2FCYEq9xiATnr/9SsFk4ruhiH0MGnNMGQMsFZfJo1rpL+7SksUAH58woinEAxgCf4Q==
                                txhash: 314C7BCBE5F7469A35D72CDFE9592A95C29007B4B39C6635A10C1202087EC796

and I see ERR in relayer:

2025-08-12 15:04:54 2025-08-12T08:04:54.559403Z ERROR ThreadId(11) spawn:chain{chain=chainA-1}:client{client=07-tendermint-0}:connection{connection=connection-0}:channel{channel=channel-0}:worker.client.misbehaviour{client=07-tendermint-0 src_chain=chainB-1 dst_chain=chainA-1}:foreign_client.detect_misbehaviour_and_submit_evidence{client=chainB-1->chainA-1:07-tendermint-0}: misbehaviour checking is being disabled, reason: cannot run misbehaviour: could not extract header from update client event UpdateClient { common: Attributes { client_id: ClientId("07-tendermint-0"), client_type: Tendermint, consensus_height: Height { revision: 1, height: 72 } }, header: None } emitted by chain chainA-1
2025-08-12 15:04:54 2025-08-12T08:04:54.559403Z ERROR ThreadId(14) spawn:chain{chain=chainB-1}:client{client=07-tendermint-0}:connection{connection=connection-0}:channel{channel=channel-0}:worker.client.misbehaviour{client=07-tendermint-0 src_chain=chainA-1 dst_chain=chainB-1}:foreign_client.detect_misbehaviour_and_submit_evidence{client=chainA-1->chainB-1:07-tendermint-0}: misbehaviour checking is being disabled, reason: cannot run misbehaviour: could not extract header from update client event UpdateClient { common: Attributes { client_id: ClientId("07-tendermint-0"), client_type: Tendermint, consensus_height: Height { revision: 1, height: 75 } }, header: None } emitted by chain chainB-1

Can you help me take a look @gjermundgaraba ?

@anhductn2001
Copy link
Contributor Author

more info:

simd q ibc channel next-sequence-send transfer channel-0
Usage:
  simd query ibc channel next-sequence-send [port-id] [channel-id] [flags]

Examples:
simd query ibc channel next-sequence-send [port-id] [channel-id]

Flags:
      --grpc-addr string   the gRPC endpoint to use for this chain
      --grpc-insecure      allow gRPC over insecure channels, if not the server must use TLS
      --height int         Use a specific height to query state at (this can error if the node is pruning state)
  -h, --help               help for next-sequence-send
      --node string        <host>:<port> to CometBFT RPC interface for this chain (default "tcp://localhost:26657")
  -o, --output string      Output format (text|json) (default "text")
      --prove              show proofs for the query results (default true)

Global Flags:
      --home string         directory for config and data (default "/root/.simapp")
      --log_format string   The logging format (json|plain) (default "plain")
      --log_level string    The logging level (trace|debug|info|warn|error|fatal|panic|disabled or '*:<level>,<key>:<level>') (default "info")
      --log_no_color        Disable colored logs
      --trace               print out full stack trace on errors

10:36AM ERR failure when running app err="portID (transfer), channelID (channel-0): channel not found"

and

simd q ibc channel channels
channels:
- channel_id: channel-0
  connection_hops:
  - connection-0
  counterparty:
    channel_id: channel-0
    port_id: transfer
  ordering: ORDER_UNORDERED
  port_id: transfer
  state: STATE_OPEN
  version: ics20-1
height:
  revision_height: "249"
  revision_number: "1"
pagination:
  next_key: null
  total: "0"

@anhductn2001
Copy link
Contributor Author

I think it's relate to #8473

@anhductn2001
Copy link
Contributor Author

nvm, I fixed it and the test passed @gjermundgaraba

--- PASS: TestUpgradeTestSuite (495.42s)
    --- PASS: TestUpgradeTestSuite/TestV10ToV11ChainUpgrade (365.38s)
        --- PASS: TestUpgradeTestSuite/TestV10ToV11ChainUpgrade/start_relayer (24.61s)
        --- PASS: TestUpgradeTestSuite/TestV10ToV11ChainUpgrade/transfer_native_tokens_from_chainA_to_chainB (13.95s)
        --- PASS: TestUpgradeTestSuite/TestV10ToV11ChainUpgrade/transfer_native_tokens_from_chainB_to_chainA (12.97s)
        --- PASS: TestUpgradeTestSuite/TestV10ToV11ChainUpgrade/stop_relayer (30.40s)
        --- PASS: TestUpgradeTestSuite/TestV10ToV11ChainUpgrade/upgrade_chain (118.88s)
        --- PASS: TestUpgradeTestSuite/TestV10ToV11ChainUpgrade/start_relayer#01 (23.27s)
        --- PASS: TestUpgradeTestSuite/TestV10ToV11ChainUpgrade/query_denoms_after_upgrade (0.00s)
        --- PASS: TestUpgradeTestSuite/TestV10ToV11ChainUpgrade/IBC_token_transfer_from_chainA_to_chainB,_to_make_sure_the_upgrade_did_not_break_the_packet_flow (18.66s)
PASS
ok      github.com/cosmos/ibc-go/e2e/tests/upgrades     496.526s

@anhductn2001 anhductn2001 marked this pull request as ready for review August 12, 2025 13:17
@anhductn2001
Copy link
Contributor Author

CI is failing because we don't have v11.0.0 tag yet. We can merge it after release tag @gjermundgaraba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjermundgaraba gjermundgaraba Awaiting requested review from gjermundgaraba

@srdtrk srdtrk Awaiting requested review from srdtrk

@DeshErBojhaa DeshErBojhaa Awaiting requested review from DeshErBojhaa

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create v11 e2e upgrade tests
1 participant
@anhductn2001