Skip to content

ICS20: Correction to the denom in the sequence diagram #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+3 −3
Open

ICS20: Correction to the denom in the sequence diagram #1229

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79ddeaf
corrected the denom that B is burning before sending back to A
ivan-gavran May 22, 2025
c3a1ad7
fixed denoms sent to A and unlocked by A
ivan-gavran May 22, 2025
df2f1f2
Apply suggestions from code review
ivan-gavran May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions spec/app/ics-020-fungible-token-transfer/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@ sequenceDiagram
chain C->>chain B: Send transfer packet with vouchers ("transfer/ChannelToB/transfer/ChannelToA/denom")
chain B->>chain B: Unlock (unescrow) vouchers ("transfer/ChannelToA/denom")
Note over chain B,chain A: B is sink zone: B -> A
chain B->>chain B: Burn vouchers ("transfer/ChannelToB/transfer/ChannelToA/denom")
chain B->>chain A: Send transfer packet with vouchers ("transfer/ChannelToB/transfer/ChannelToA/denom")
chain A->>chain A: Unlock (unescrow) vouchers ("transfer/ChannelToA/denom")
chain B->>chain B: Burn vouchers ("transfer/ChannelToA/denom")
chain B->>chain A: Send transfer packet with vouchers ("transfer/ChannelToA/denom")
chain A->>chain A: Unlock (unescrow) tokens ("denom")
```

The acknowledgement data type describes whether the transfer succeeded or failed, and the reason for failure (if any).
Expand Down