Added advice #2
Open
Added advice #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pastjean
approved these changes
Jan 20, 2017
| @@ -42,3 +42,4 @@ Mais ne copie pas de code! On va le savoir :) | |||
| - N'hésite pas à ajouter des fonctionnalités! Nous sommes curieux de voir ce à quoi tu peux penser. Nous nous attendrons à la même chose si tu travailles avec nous. | |||
| - La documentation et la maintenabilité est un plus. | |||
| - N'oublie pas les tests unitaires. | |||
| - On ne cherche pas à savoir si vous pouvez uniquement suivre des instructions (sinon tous les résultats seraient pareils). On veut savoir qu'est-ce que **tu** contribues lorsque tu travailles sur un projet. C'est quoi ton secret. Plus de fonctionnalités? Meilleure solution? Idées originales? | |||
There was a problem hiding this comment.
...quel genre de contribution tu amènes lorsque tu travailles sur un projet...
wording, je trouvais le qu'est-ce que tu contribues louche à lire
There was a problem hiding this comment.
... On ne cherche pas à savoir si tu pouvez uniquement suivre des instructions ...
vous -> tu , on tutois partout dans le reste du texte
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.