-
Notifications
You must be signed in to change notification settings - Fork 39
chore: sync-up arborist & npm, add missing vitest.config.js, add missing eslint-parser #6048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
|
it was only present transitively before, which explains the issue
@coveo/salesforce-integration , while you may review all the PR, the changeset specific to your purview are curtailed to 81194f1 |
0158d9a
to
87bf12e
Compare
fbeaudoincoveo
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A triple whammy that is blocking the CI.
7ca9410 Unsynced Arborist & NPM blocks
npm ci
after releasesWith Arborist 9.1.3, a tune-up on the Arborist algorithm was made so that optional "dangling" (i.e. without actual explicit dependency/ask) are now removed when the tree is reifed. See npm/cli#8431
However, NPM 11.4.2 was explicitly using Arborist 9.1.2, which does not do that.
This caused a discrepancy between the package-lock check executed by
npm ci
(using arborist 9.1.2) and the result of our reify (using arborist 9.1.3/4).One of the particularities of
npm ci
is that it fails early if the package-lock seems inadequate/incomplete, leading tonpm ci
failing as long as the version of arborist we use is out-of-sync (and incompatible) with the one used by thenpm
version that we use.Why do we reify?
We elected to run manual update operations using Arborist over using the npm-cli to avoid changes to the transitive dependency during the release process:
Indeed, we do not necessarily want to "unfreeze" our transitive dependency at release time; we just want to "bump" the version of our packages
What's the fix-it-twice?
Switching to
pnpm
with its default options (notablypreferFrozenLockFile
) and replacing the reify script withpnpm up --workspace
should fix the issue by using the same code-path (i.e. pnpm) for all lockfile operations.81194f1 Quantic's ESLint config is using a Typescript parser transitively instead of directly
The improvement of NPM/Arborist in the "pruning" and clean-up of the dependency tree, combined with the transition out of ESLint of the repo revelead an underlying issue in Quantic's eslint setup.
Indeed, it's using
@typescript-eslint/parser
without explicitly having it in its development dependencies. Fix's easy: add it up.87bf12e Missing
vitest.config.js
causesnpm test
on bueno to be confused since #6019Without this, Vitest tries to run Bueno's test with the first Vitest config listed in the root vitest.config.js, which is one of Atomic.
We didn't detect it before because we did not run UT on Bueno, given that we only ran the affected tests. Modifying
utils/ci
causesbueno
test to run because bueno depends onutils/ci
.https://coveord.atlassian.net/browse/KIT-5014