chore(atomic): add mockConsole testing util #6132
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbeaudoincoveo
had a problem deploying
to
PR Artifacts
GitHub Actions
Error
fbeaudoincoveo
had a problem deploying
to
PR Artifacts
GitHub Actions
Error
fbeaudoincoveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fbeaudoincoveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
|
fbeaudoincoveo
temporarily deployed
to
Prerelease (CDN)
GitHub Actions
Inactive
fbeaudoincoveo
temporarily deployed
to
Prerelease
GitHub Actions
Inactive
fbeaudoincoveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new util will allow us to mock the console in a consistent way in our component tests, and get rid of the global
console.errormock we're currently doing in atomic/vitest-utils/setup.ts.The util spies on the console
error,log, andwarnmethods, and by default uses a blank implementation to keep the logs clean (we can passloud: trueto use the original implementations).https://coveord.atlassian.net/browse/KIT-5115