chore (atomic): migrated atomic-result-template to lit #6159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmazzah-coveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
jmazzah-coveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
jmazzah-coveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
jmazzah-coveo
temporarily deployed
to
Prerelease (CDN)
GitHub Actions
Inactive
jmazzah-coveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
jmazzah-coveo
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
jmazzah-coveo
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
jmazzah-coveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
jmazzah-coveo
temporarily deployed
to
Prerelease (CDN)
GitHub Actions
Inactive
jmazzah-coveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
jmazzah-coveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
jmazzah-coveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
jmazzah-coveo
temporarily deployed
to
Prerelease (CDN)
GitHub Actions
Inactive
jmazzah-coveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
jmazzah-coveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
jmazzah-coveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
jmazzah-coveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
jmazzah-coveo
temporarily deployed
to
Prerelease (CDN)
GitHub Actions
Inactive
jmazzah-coveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fpbrault
approved these changes
Oct 15, 2025
Comment on lines
19
to
20
| * @MapProp name: mustMatch;attr: must-match;docs: The field and values that must be matched by a result item for the template to apply. For example, a template with the following attribute only applies to result items whose `sourcetype` is `YouTube` or `Salesforce`: `must-match-sourcetype="YouTube,Salesforce"`;type: Record<string, string[]> ;default: {} | ||
| * @MapProp name: mustNotMatch;attr: must-not-match;docs: The field and values that must not be matched by a result item for the template to apply. For example, a template with the following attribute only applies to result items whose `sourcetype` is not `YouTube`: `must-not-match-sourcetype="YouTube"`;type: Record<string, string[]> ;default: {} |
There was a problem hiding this comment.
I don't think this is used in storybook. Also, it should probably be @mapProperty now?
|
|
||
| ## Template Conditions | ||
|
|
||
| You can use conditions to display different templates based on result properties: |
There was a problem hiding this comment.
Does the order of "declaration" matter?
E.g., if the default template precedes the youtube template in the markup, will the default template apply even to youtube results?
Whether declaration order matters or not, we should document this behavior because right now it's not clear.
packages/atomic/src/components/search/atomic-result-template/atomic-result-template.mdx
Show resolved
Hide resolved
...s/atomic/src/components/search/atomic-result-template/atomic-result-template.new.stories.tsx
Outdated
Show resolved
Hide resolved
...s/atomic/src/components/search/atomic-result-template/atomic-result-template.new.stories.tsx
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/search/atomic-result-template/atomic-result-template.spec.ts
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/search/atomic-result-template/atomic-result-template.spec.ts
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/search/atomic-result-template/atomic-result-template.spec.ts
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/search/atomic-result-template/atomic-result-template.spec.ts
Outdated
Show resolved
Hide resolved
jmazzah-coveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
jmazzah-coveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
jmazzah-coveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
jmazzah-coveo
temporarily deployed
to
Prerelease (CDN)
GitHub Actions
Inactive
jmazzah-coveo
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
.mdxfileindex.tsandlazy-index.tsfiles.https://coveord.atlassian.net/browse/KIT-4963
Note: This Pull Request contains files from the reactive controllers. You can ignore them as they have already been reviewed and are waiting for final approval to be merged.