-
Notifications
You must be signed in to change notification settings - Fork 39
chore(quantic): move playwright setup to docker #6167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
|
8873f2d
to
5ebdc8b
Compare
5ebdc8b
to
bca9911
Compare
bca9911
to
f201122
Compare
f201122
to
bb09263
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
I see that changes in this PR didn't trigger the run of E2E tests here: https://github.com/coveo/ui-kit/actions/runs/18550935009?pr=6167 because these currently run only when a change occurs in the Headless folder or the Quantic folder, that's something we could improve as it's very relevant to run these in such PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Indeed! |
Similar to #6139 , for quantic.
Without Docker:


With Docker:
Caches & sometimes don't play nicely together, and here, the cache is not really the right API in retrospect (we changed this recently, too, for turborepo build cache, for example), hence artifacts.
KIT-5133