Skip to content

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented Oct 15, 2025

Similar to #6139 , for quantic.

Without Docker:
image
With Docker:
image

Caches & sometimes don't play nicely together, and here, the cache is not really the right API in retrospect (we changed this recently, too, for turborepo build cache, for example), hence artifacts.

KIT-5133

@developer-experience-bot
Copy link
Contributor

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 255.6 255.6 0
commerce 369.4 369.4 0
search 427.1 427.1 0
insight 418.3 418.3 0
recommendation 266.4 266.4 0
ssr 421.5 421.5 0
ssr-commerce 386.5 386.5 0
ssr-commerce-next 387.8 387.8 0
ssr-next 422.1 422.1 0

Copy link

github-actions bot commented Oct 16, 2025

🔗 Scratch Orgs ready to test this PR:

@louis-bompart louis-bompart changed the title chore: move quantic to docker too? chore(quantic): move playwright setup to docker Oct 16, 2025
@louis-bompart louis-bompart marked this pull request as ready for review October 16, 2025 05:05
@louis-bompart louis-bompart requested review from a team as code owners October 16, 2025 05:05
@louis-bompart louis-bompart force-pushed the chore/docker-playwright-quantic-too branch from f201122 to bb09263 Compare October 16, 2025 05:08
Copy link
Contributor

@vhilotii-coveo vhilotii-coveo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mmitiche
Copy link
Contributor

I see that changes in this PR didn't trigger the run of E2E tests here: https://github.com/coveo/ui-kit/actions/runs/18550935009?pr=6167 because these currently run only when a change occurs in the Headless folder or the Quantic folder, that's something we could improve as it's very relevant to run these in such PRs.

Copy link
Contributor

@mmitiche mmitiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@louis-bompart
Copy link
Collaborator Author

I see that changes in this PR didn't trigger the run of E2E tests here: https://github.com/coveo/ui-kit/actions/runs/18550935009?pr=6167 because these currently run only when a change occurs in the Headless folder or the Quantic folder, that's something we could improve as it's very relevant to run these in such PRs.

Indeed!

@louis-bompart louis-bompart added this pull request to the merge queue Oct 16, 2025
Merged via the queue into main with commit 2c7e17a Oct 16, 2025
42 checks passed
@louis-bompart louis-bompart deleted the chore/docker-playwright-quantic-too branch October 16, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants