TypeLoadException error (DependencyInjection) with latest EFCore

[leodip]

Hi,

I noticed that if I upgrade my EF Core libraries to latest (6.0.10), I get an error with coverlet:

Data collector 'XPlat code coverage' message: [coverlet]System.TypeLoadException: Could not load type 'Microsoft.Extensions.DependencyInjection.ServiceCollection' from assembly 'Microsoft.Extensions.DependencyInjection, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'.
   at Coverlet.Collector.DataCollection.CoverletCoverageCollector.GetDefaultServiceCollection(TestPlatformEqtTrace eqtTrace, TestPlatformLogger logger, String testModule)
   at Coverlet.Collector.DataCollection.CoverletCoverageCollector.OnSessionStart(Object sender, SessionStartEventArgs sessionStartEventArgs) in /_/src/coverlet.collector/DataCollection/CoverletCoverageCollector.cs:line 132.

I'm trying to upgrade Microsoft.EntityFrameworkCore from 6.0.9 to 6.0.10. My project is latest .NET 6.

Is this happening to anyone else? Is there a fix?

[cheesi]

Yes, we have the same issue, I can confirm that we also updated all Microsoft & EF Core packages today, however, I haven't check if it is related as our pipelines didn't break. But if @leodip has it already figured out, that EF Core is the issue, it is most likely same reason for us.

[Krashlog]

Actually, I think it's Microsoft.Extensions.DependencyInjection 6.0.1 that is problematic (as a dependency of both EF Core and coverlet). Downgrading to 6.0.0 solved the problem in our Azure pipelines.

[KlemensGenetec]

Got the same issue. When calling dotnet test with --collect:XPlat Code Coverage I get the error

Data collector 'XPlat code coverage' message: [coverlet]System.TypeLoadException: Could not load type 'Microsoft.Extensions.DependencyInjection.ServiceCollection' from assembly 'Microsoft.Extensions.DependencyInjection, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'. at Coverlet.Collector.DataCollection.CoverletCoverageCollector.GetDefaultServiceCollection(TestPlatformEqtTrace eqtTrace, TestPlatformLogger logger, String testModule) at Coverlet.Collector.DataCollection.CoverletCoverageCollector.OnSessionStart(Object sender, SessionStartEventArgs sessionStartEventArgs) in /_/src/coverlet.collector/DataCollection/CoverletCoverageCollector.cs:line 132.

It must be related to DependencyInjection 6.0.0 not being present in our project anymore. Funnily enough when using CollectCoverage=true in dotnet test, which causes it to use msbuild it didnt have that issue.

[daveMueller]

Could somebody try to provide a simple repro for that? I just tried it myself with a simple console app referencing Microsoft.Extensions.DependencyInjection 6.0.1 but didn't face this issue.

[KlemensGenetec]

Also tried now but it doesn't seem to be that easy to reproduce it. I just included EntityFrameworkCore as I did in the other project and used WebApplicationFactory for testing as well but i couldn't see the issue either.
So there seems to be more to it than I thought.

[candritzky]

Same here and definitely related to .NET 6.0.10, but not directly to EF Core.

Seems like the ServiceCollection class was been moved from Microsoft.Extensions.DependencyInjection.dll into Microsoft.Extensions.DependencyInjection.Abstractions.dll.
But this happened a long time ago, long before .NET 6 was released.
See dotnet/runtime@ad7455c

Maybe it happens because coverlet.console still targets net5.0.
See

coverlet/src/coverlet.console/coverlet.console.csproj

Line 5 in 5637470

<TargetFramework>net5.0</TargetFramework>

[candritzky]

Happens because of the updated Microsoft.Extensions.DependencyInjection NuGet package (now version 6.0.1). This results in a newer Microsoft.Extensions.DependencyInjection.dll being copied to the bin folder (still assembly version 6.0.0.0).

If you either delete the DLL from the bin folder before running the tests, or if you manually copy Microsoft.Extensions.DependencyInjection.Abstractions.dll (from NuGet package 6.0.0 which is still latest) to the bin folder, then code coverage is working again.

Really strange...

[KlemensGenetec]

Got a sample working where i got the error. Hopefully its not just on my machine. For some reason it is the combination of App insights and EF.

Then did the following command: dotnet test "--collect:XPlat Code Coverage" --configuration Release --logger trx --results-directory result

console-app-master.zip

[cheesi]

Hey!
I downloaded the sample from @KlemensGenetec and can confirm, I got the same error. So it seems to be a machine independent working reproduction.

❯   dotnet test "--collect:XPlat Code Coverage" --configuration Release --logger trx --results-directory result
  Determining projects to restore...
  Restored C:\Users\Christian\Downloads\console-app-master\src\TemplateApp.ConsoleApp\TemplateApp.ConsoleApp.csproj (in 495 ms).
  Restored C:\Users\Christian\Downloads\console-app-master\tests\TemplateApp.Application.Tests\TemplateApp.Application.Tests.csproj (in 1,56 sec).
  TemplateApp.ConsoleApp -> C:\Users\Christian\Downloads\console-app-master\src\TemplateApp.ConsoleApp\bin\Release\net6.0\TemplateApp.ConsoleApp.dll
  TemplateApp.Application.Tests -> C:\Users\Christian\Downloads\console-app-master\tests\TemplateApp.Application.Tests\bin\Release\net6.0\TemplateApp.Application.Tests.dll
Test run for C:\Users\Christian\Downloads\console-app-master\tests\TemplateApp.Application.Tests\bin\Release\net6.0\TemplateApp.Application.Tests.dll (.NETCoreApp,Version=v6.0)
Microsoft (R) Test Execution Command Line Tool Version 17.3.1 (x64)
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
Data collector 'XPlat code coverage' message: [coverlet]System.TypeLoadException: Could not load type 'Microsoft.Extensions.DependencyInjection.ServiceCollection' from assembly 'Microsoft.Extensions.DependencyInjection, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'.
   at Coverlet.Collector.DataCollection.CoverletCoverageCollector.GetDefaultServiceCollection(TestPlatformEqtTrace eqtTrace, TestPlatformLogger logger, String testModule)
   at Coverlet.Collector.DataCollection.CoverletCoverageCollector.OnSessionStart(Object sender, SessionStartEventArgs sessionStartEventArgs) in /_/src/coverlet.collector/DataCollection/CoverletCoverageCollector.cs:line 132.
test

Results File: C:\Users\Christian\Downloads\console-app-master\result\Christian_WORKSTATION_2022-10-18_19_02_04.trx

Passed!  - Failed:     0, Passed:     1, Skipped:     0, Total:     1, Duration: 207 ms - TemplateApp.Application.Tests.dll (net6.0)

[Krashlog]

I can repro too, using @KlemensGenetec sample.

Simply removing the AppInsight nuget package is enough for the tests to work again.

[rodchenkov]

I have the same issue, can someone suggest a solution for pipeline?

[KlemensGenetec]

You can use something similar to dotnet test /p:CollectCoverage=true /p:CoverletOutputFormat=opencover --configuration Release --logger trx --results-directory result

Then you need to make sure that <IsTest>true</IsTest> is in the test project and probably add <PackageReference Include="coverlet.msbuild" Version="3.1.2"> to the test project too.

That will work if you have msbuild installed.