coverlet.msbuild 2.3.0 rebuilds the project with not enough information

[akshaybheda]

Hi,

I am using coverlet.msbuild 2.3.0 with Shouldly package. It looks like whenever i try to enable codecoverage, some of my test fails as the coverlet rebuilds the project which are referenced from my test project with less than Debug level information. I can see the difference in the sizes of dll.

When i build the project with dotnet build, it builds the project with Debug level information set to Full. and when i add coverlet.msbuild to my test project and enable the code coverage and run the test with dotnet test --no-build. It still rebuilds the testee projects. and due to that some of my tests fail as the Shoudly requires full debug information to generate exception messages.

[tonerdo]

Hi @akshaybheda, is you debug information embedded or in a separate PDB file?

[akshaybheda]

Its in separate PDB file. the pdb size remains the same but the dll changes. dll of the projects referenced by my test

[akshaybheda]

@tonerdo I have created a sample repository https://github.com/akshaybheda/coverletissuedemo which you can clone at your end and i have mentioned the steps which causes the issue.

[akshaybheda]

@tonerdo I also tried to change my application to .netcore2.2 with all updated packages, i face the same issue that the coverlet modifies the source dll which doesnt match with pdb's

[tonerdo]

@akshaybheda sorry for letting this slide. I think what's happening here is that after Coverlet rewrites the dll, the debug information in the pdb file is no longer aligned with the contents of the dll.

The way to fix this is to make coverlet update the debug information to align with the new state of the dll. Might be a bit of work on my end and can't give a definite time when I'll be able to get to it.

By the way, Coverlet doesn't rebuild the dll, it just instruments it by adding some extra code

[tonerdo]

#318 updates the Instrumenter to write new symbol information after instrumentation. New NuGet bits with this change will within in 24 hours