-
Notifications
You must be signed in to change notification settings - Fork 392
Fix bug: exception filters appear on the wrong line #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug: exception filters appear on the wrong line #344
Conversation
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
==========================================
- Coverage 87.1% 86.94% -0.17%
==========================================
Files 31 31
Lines 3033 3080 +47
==========================================
+ Hits 2642 2678 +36
- Misses 391 402 +11 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
==========================================
- Coverage 87.1% 86.94% -0.17%
==========================================
Files 31 31
Lines 3033 3080 +47
==========================================
+ Hits 2642 2678 +36
- Misses 391 402 +11 |
@hughbe if you've some time can you try this update with your project?I cannot compile, build fail. Steps:
<?xml version="1.0" encoding="utf-8"?>
<configuration>
<packageSources>
<clear />
<add key="localcoverlet" value="C:\git\coverlet\build\Release" />
<add key="nuget" value="https://api.nuget.org/v3/index.json" />
</packageSources>
</configuration>
You should refer /cc @pape77 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Ready to go once you fix up the merge conflicts
It's not a merge issue, it's new github features "draft pr" https://github.blog/2019-02-14-introducing-draft-pull-requests/ I'm waiting if @hughbe can try this update, @pape77 says that it's ok, but two green light should be better |
Done thank's! |
Lol, I didn't even read the message but just assumed it was a conflict. |
@tonerdo no response I think we can go on with this |
great thank's to @pape77 my private beta tester 😘 |
fixes #278
/cc @tonerdo @petli