Skip to content

Conversation

MarcoRossignoli
Copy link
Collaborator

fixes #278

/cc @tonerdo @petli

@codecov
Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #344 into master will decrease coverage by 0.16%.
The diff coverage is 76.59%.

@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
- Coverage    87.1%   86.94%   -0.17%     
==========================================
  Files          31       31              
  Lines        3033     3080      +47     
==========================================
+ Hits         2642     2678      +36     
- Misses        391      402      +11

1 similar comment
@codecov
Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #344 into master will decrease coverage by 0.16%.
The diff coverage is 76.59%.

@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
- Coverage    87.1%   86.94%   -0.17%     
==========================================
  Files          31       31              
  Lines        3033     3080      +47     
==========================================
+ Hits         2642     2678      +36     
- Misses        391      402      +11

@MarcoRossignoli
Copy link
Collaborator Author

MarcoRossignoli commented Feb 18, 2019

@hughbe if you've some time can you try this update with your project?I cannot compile, build fail. Steps:

  1. Clone this branch
  2. build package
C:\git\coverlet (exceptionfilter -> origin)
λ msbuild /t:CreateNuGetPackage /p:Configuration=Release build.proj
...
Successfully created package 'C:\git\coverlet\build\Release\coverlet.console.1.4.1.nupkg'
  1. Add Nuget.Config on root of you solution:
<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <packageSources>
    <clear />
    <add key="localcoverlet" value="C:\git\coverlet\build\Release" />
    <add key="nuget" value="https://api.nuget.org/v3/index.json" />
  </packageSources>
</configuration>

You should refer coverlet.msbuild.2.5.1.nupkg and try to restore/test

/cc @pape77

Copy link
Collaborator

@tonerdo tonerdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ready to go once you fix up the merge conflicts

@MarcoRossignoli
Copy link
Collaborator Author

MarcoRossignoli commented Feb 18, 2019

LGTM! Ready to go once you fix up the merge conflicts

It's not a merge issue, it's new github features "draft pr" https://github.blog/2019-02-14-introducing-draft-pull-requests/

I'm waiting if @hughbe can try this update, @pape77 says that it's ok, but two green light should be better

@MarcoRossignoli
Copy link
Collaborator Author

Use single :)

Done thank's!

@tonerdo
Copy link
Collaborator

tonerdo commented Feb 18, 2019

It's not a merge issue, it's new github features "draft pr"

Lol, I didn't even read the message but just assumed it was a conflict.

@MarcoRossignoli MarcoRossignoli marked this pull request as ready for review February 21, 2019 11:07
@MarcoRossignoli
Copy link
Collaborator Author

@tonerdo no response I think we can go on with this

@MarcoRossignoli
Copy link
Collaborator Author

MarcoRossignoli commented Feb 21, 2019

great thank's to @pape77 my private beta tester 😘

@tonerdo tonerdo merged commit 60c4f9e into coverlet-coverage:master Feb 23, 2019
@MarcoRossignoli MarcoRossignoli deleted the exceptionfilter branch February 26, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception filters appear on the wrong line
3 participants