Skip to content

Revert "Using File.Exists for HitsFile creation/update validation" #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2019
Merged

Revert "Using File.Exists for HitsFile creation/update validation" #498

merged 1 commit into from
Jul 24, 2019

Conversation

MarcoRossignoli
Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli commented Jul 24, 2019 •
edited
Loading

Reverts #415

This change broke System.Private.CoreLib code coverage measurement as System.IO.File is not available in it.

@MarcoRossignoli
Copy link
Collaborator Author

cc: @ViktorHofer @tonerdo

@MarcoRossignoli MarcoRossignoli added the bug Something isn't working label Jul 24, 2019
@MarcoRossignoli MarcoRossignoli merged commit ed9195d into master Jul 24, 2019
@MarcoRossignoli MarcoRossignoli deleted the revert-415-FileExists branch July 24, 2019 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcoRossignoli @ViktorHofer