Revert "Add [xunit*]* to default excluded modules filter if not specified"

[MarcoRossignoli]

Reverts #462

With #510 now we exclude from instrumentation module with embedded pdb without local source.
For this reason we could think to remove xunit filter from code as @tonerdo told here #510 (comment)
We could keep filter as fallback in case that xunit for some reason will move embedded pdb to local folder(@onovotny talked about it here #510 (comment))

Personally I would keep filter for the moment, but yes could be unuseful/dead code.

Thoughts? @tonerdo @vagisha-nidhi @onovotny @ViktorHofer
Maybe @bradwilson could also be useful here to confirm or not something.

Ah one more thing, if someone know the name of nuget package that download pdb on output directory please let me know...so we can write code/test to skip also that case.

[tonerdo]

@MarcoRossignoli what do you mean by

We could keep filter as fallback in case that xunit for some reason will move embedded pdb to local

This change seems legit to me as it's unlikely for the xunit source files to be on a user's machine except they work on xunit itself

[MarcoRossignoli]

This change seems legit to me as it's unlikely for the xunit source files to be on a user's machine except they work on xunit itself

@tonerdo I mean that for the moment we check for source only for embedded pdb, so if for some reason(unlikely I think) move pdb to local target folder we won't check for source but we'll try to instrument

[tonerdo]

Oh I see. Well we should update the code to check for local sources for both embedded and standalone pdb

[MarcoRossignoli]

Oh I see. Well we should update the code to check for local sources for both embedded and standalone pdb

I agree as I've asked to Oren I would like to write a test on it, but I need a "sample" nuget package that behave like that (before build one tailored made)...@tonerdo do you know one?

[clairernovotny]

Try Microsoft.Toolkit. It has a pdb in it with sourcelink data in it:

[MarcoRossignoli]

Great thanks Oren! I'm on vacancy until next week, I'll give it a try asap!

[bradwilson]

I can't imagine we (@xunit) would ever go back to external PDBs.

[MarcoRossignoli]

Thanks @bradwilson for info
@tonerdo we can merge for now...I'll update with external pdbs on new PR