Skip to content

Fix skip [ExcludefromCoverage] for generated async state machine #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 18, 2020
Merged

Fix skip [ExcludefromCoverage] for generated async state machine #849

merged 8 commits into from
May 18, 2020

Conversation

MarcoRossignoli
Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli commented May 16, 2020 •
edited
Loading

Contributes to #809
We need also to fix issue with lamda.

NB. Cannot add tests because in all other case the ordinal value calculation is correct so I cannot find an example where old alg(synthetized names) fails.

cc: @matteoerigozzi @VenkateshSrini

@MarcoRossignoli
Copy link
Collaborator Author

MarcoRossignoli commented May 16, 2020 •
edited
Loading

Local manual test with repro

image

Bug still present for lambda

image

@MarcoRossignoli MarcoRossignoli added bug Something isn't working tenet-coverage Issue related to possible incorrect coverage labels May 16, 2020
matteoerigozzi
matteoerigozzi reviewed May 16, 2020
View reviewed changes
Copy link
Contributor

@matteoerigozzi matteoerigozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM a test would be necessary

@MarcoRossignoli
Copy link
Collaborator Author

@matteoerigozzi PTAL

@MarcoRossignoli
Copy link
Collaborator Author

MarcoRossignoli commented May 17, 2020 •
edited
Loading

Test case with lambda bug
image
image

@MarcoRossignoli MarcoRossignoli merged commit d70cb64 into coverlet-coverage:master May 18, 2020
@MarcoRossignoli MarcoRossignoli deleted the fix_809 branch May 18, 2020 06:43
@extesy extesy mentioned this pull request Oct 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@matteoerigozzi matteoerigozzi matteoerigozzi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug Something isn't working tenet-coverage Issue related to possible incorrect coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcoRossignoli @matteoerigozzi