Mention the actual missing path in exception output when SourceRootTranslator constructor fails. #990
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the SourceRootTranslator constructor fails due to a missing file, the actual path is not mentioned. Instead, the output mentiones the csproj file after the error message, misleading the user into thinking that the project file could not be found or accesed:
This patch includes the path of the missing file in the exception message, so the user knows which file actually could not be found:
My guess is that performance is not really negatively affected, as this only happens in a code path where the test execution fails anyways.
I also hope this qualifies as "very small change" according to https://github.com/coverlet-coverage/coverlet/blob/master/CONTRIBUTING.md, so I did not open an issue before the merge request. :-)