[re.regiter.general] Move const into \tcode #7878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwakely
approved these changes
May 16, 2025
| @@ -12238,8 +12238,8 @@ | |||
| constructs an end-of-sequence iterator object, | |||
| which is the only legitimate iterator to be used for the end | |||
There was a problem hiding this comment.
This is somewhat misleading since we added comparison with default_sentinel_t although that's not actually an iterator so it's technically true, just misleading.
| @@ -12238,8 +12238,8 @@ | |||
| constructs an end-of-sequence iterator object, | |||
| which is the only legitimate iterator to be used for the end | |||
| condition. The result of \tcode{operator*} on an end-of-sequence iterator is not | |||
There was a problem hiding this comment.
Most of this prose is just repeating general iterator requirements (you can't dereference the end iterator, dereferencing it returns the iterator's reference type etc).
jensmaurer
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.