Error after recent update (v2.16.0)

[mccrearyp]

What events trigger your workflow?

on:
  pull_request:
    branches: ["develop"]

What OS does your workflow use?

AnnotateLint:
    runs-on:
      group: Default
    container:
      image: 10.10.10.11:5000/ubuntu-dev:latest

How is cpp-linter-action configured?

- name: Lint
        id: linter
        if: github.event.pull_request.changed_files <= 300
        uses: cpp-linter/cpp-linter-action@v2
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        with:
          style: "chromium"
          tidy-checks: "bugprone-*,performance-*,readability-*,modernize-*,clang-analyzer-*"
          version: 19
          ignore: ${{ steps.generate_ignore_list.outputs.ignore_filter}}
          extensions: "hpp,cpp"
          database: ".build/Debug"
          extra-args: "-std=c++20 -Wall"
          step-summary: true
          lines-changed-only: true
          thread-comments: ${{ github.event_name == 'pull_request' && 'update' }}

What was the unexpected behavior?

Getting this error after the recent update. I have a container running this action and I think this error my be related python installing the packages. Do I need to be on a newer version of python?

Ensuring clang-format and clang-tidy 19 are present
error: Failed to spawn: `clang-tools`
  Caused by: No such file or directory (os error 2)
Error: Process completed with exit code 2.

[lhearachel]

A project that I maintain is seeing similar failures with the following configuration:

What events trigger your workflow?

name: pr-lint
on:
  pull_request:
    branches: [main]
    paths: ['**.c', '**.h']

What OS does your workflow use?

ubuntu-latest

How is cpp-linter-action configured?

jobs:
  pr-lint:
    runs-on: ubuntu-latest

    permissions:
      contents: read
      pull-requests: read

    steps:
      - uses: actions/checkout@v4

      - uses: cpp-linter/cpp-linter-action@v2
        id: linter
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        with:
          style: 'file' # Use repository .clang-format file
          tidy-checks: '-*' # Disable clang-tidy checks
          version: '19'
          files-changed-only: false # Github returns error code 406 if more than 300 files are changed in a PR
          ignore: '.github|lib|subprojects|tools'
          file-annotations: false

      - name: fail fast
        if: steps.linter.outputs.clang-format-checks-failed > 0
        run: exit 1

[2bndy5]

I think I found the fix. I'm still battle testing it in the fix-venv branch. So far, the branch is working in our test repo (which is a different env from this repo's self-test CI).

[2bndy5]

Ok, I have verified that the fix will work in github-hosted runners that don't use specialized containers (the usage in @lhearachel's case).

@mccrearyp Would it be too much trouble to try the fix-venv branch?

      uses: cpp-linter/cpp-linter-action@fix-venv

At this point, I'm more concerned about paths when using a container image. That is something we don't typically test for.

[2bndy5]

I am having a HELLISH time trying to set up a CI workflow that has cmake, gcc, and g++ available. This may sound like a noob thing, but since when is sudo not available in a debian-based docker container?

[shenxianpeng]

I have marked v2.16.0 as pre-release now for the users who use it like uses: cpp-linter/cpp-linter-action@vX.X.X, this way, the bot won’t bump the version automatically.

@2bndy5 Should we also update the v2 tag to point to the previous version? It might be an overuse of tags, but it’s a quick way to resolve the issue for users relying on v2, giving you time to work on a proper fix.

[2bndy5]

Should we also update the v2 tag to point to the previous version?

yes, that should help prevent further disruptions for users. Rolling tags are pretty standard for github actions. The git docs, as written by Linus himself, strongly discourage moving tags on the remote, but he has been known to have a narrow point of view.

I finally got a CI workflow to use a container. Now I'm rewriting certain steps in action.yml to rely more on nushell instead of bash, where things like sudo, wget, and curl are not guaranteed to be present.

[shenxianpeng]

Should we also update the v2 tag to point to the previous version?

Done. I have updated the v2 tag to point to the last stable release v2.15.1.

[mccrearyp]

Confirmed, looks like the latest released fixed everything. Thank you!

[2bndy5]

We didn't release the fix yet. We just rolled back the v2 tag.