Skip to content

lines-changed-only should assert files-changed-only implicitly #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2bndy5 opened this issue Aug 11, 2022 · 0 comments
Closed

lines-changed-only should assert files-changed-only implicitly #82

2bndy5 opened this issue Aug 11, 2022 · 0 comments

Comments

@2bndy5
Copy link
Collaborator

2bndy5 commented Aug 11, 2022 •
edited
Loading

User intuition probably implies that the lines-changed-only option should implicitly mean files-changed-only is true, but this is not the case under the hood.

I think this is partially implemented in #81 (as part of the solution to #74), but it would be better to make the source explicitly change the value of files-changed-only if lines-changed-only is not disabled.
@2bndy5 2bndy5 mentioned this issue Aug 11, 2022
Closed
5 tasks
2bndy5 added a commit that referenced this issue Aug 11, 2022
@2bndy5
resolve #82
0a8a7a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@2bndy5