Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 10, 2023

Bumps cpp-linter from 1.6.0 to 1.6.1.

Release notes

Sourced from cpp-linter's releases.

thread-comments improvement and bug fixes

What's Changed

Full Changelog: cpp-linter/cpp-linter@v1.6.0...v1.6.1

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [cpp-linter](https://github.com/cpp-linter/cpp-linter) from 1.6.0 to 1.6.1.
- [Release notes](https://github.com/cpp-linter/cpp-linter/releases)
- [Commits](cpp-linter/cpp-linter@v1.6.0...v1.6.1)

---
updated-dependencies:
- dependency-name: cpp-linter
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Nov 10, 2023
@shenxianpeng
Copy link
Collaborator

shenxianpeng commented Nov 10, 2023

I have assigned this (fix #158) to you for cutting a new release. thank you @2bndy5

@2bndy5
Copy link
Collaborator

2bndy5 commented Nov 10, 2023

Thanks. I do want to run some tests on the test repo using this dependabot branch...

better explain no-lgtm default value

pass no-lgtm to py pkg cli
@2bndy5 2bndy5 force-pushed the dependabot/pip/cpp-linter-1.6.1 branch from 7a7c8eb to 4c88006 Compare November 10, 2023 22:57
demonstrates how to update comments (in a PR only) instead of posting new ones.
Copy link
Collaborator

@2bndy5 2bndy5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests worked as expected.

I also changed the cpp-lint-action.yml on master branch of test repo so we can get back to testing with a compilation database from PRs on this repo.

I added to the example in README to show how to 'update' comments in only PR threads. This is a common solution for users misunderstanding the expected behavior of thread-comments.

@2bndy5 2bndy5 requested a review from shenxianpeng November 11, 2023 00:27
@2bndy5 2bndy5 merged commit 5f07d64 into main Nov 11, 2023
@2bndy5 2bndy5 deleted the dependabot/pip/cpp-linter-1.6.1 branch November 11, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning: 2 File(s) not formatted (should be 1) Option to only post thread comment when errors are detected

2 participants